Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefly 1608 redis messaging caching #1685

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Firefly 1608 redis messaging caching #1685

wants to merge 3 commits into from
+1,704 −1,294

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Dec 21, 2024 •
edited
Loading

https://jira.ipac.caltech.edu/browse/FIREFLY-1608
https://jira.ipac.caltech.edu/browse/FIREFLY-1611

https://github.com/IPAC-SW/irsa-ife/pull/373/files

Migration to Redis and Cache Enhancements

Key Changes

  1. Migration to Redis:

    • Replaced the existing replicating cache with Redis for improved scalability and performance.
    • Transitioned from the current messaging system to Redis Pub/Sub for enhanced communication capabilities.
    • Redis will save and recover from disk

  2. Support for standalone mode:

    • Bundled local Redis server to support when Firefly is running in standalone mode (single instance)

  3. Code Cleanup:

    • Removed all replication cache.
    • Removed cache 'sharing' requirement.
    • Renamed and consolidated existing cache buckets to align with the new usage patterns and remove legacy references to Ehcache.

  4. Test Coverage:

    • Added tests to cover additional functionalities and ensure system reliability after the migration.

Testing and Verification

  • Need to verify that the new Redis-based cache and messaging system function correctly in local and multi-instance setups.
  • Run unit and integration tests to validate the changes.
  • Added redis deployment to Helm Charts.
  • Verify that the deployment works as intended.

https://fireflydev.ipac.caltech.edu/firefly-1608-redis-messaging-caching/firefly/ (3 instances)
https://firefly-1608-redis-messaging-caching.irsakudev.ipac.caltech.edu/applications/Spitzer/SHA/ (standalone)

Should run Python API and Notebook tests on the Firefly test deployment.

@loitly
FIREFLY-1608: Switch to Redis for Caching and Messaging
5d90345 
- Migrate the existing replicating cache to Redis.
- Transition from the current messaging system to Redis pub/sub for improved communication. (Mostly completed.)
- Support local Redis server for single instance Firefly.
- Write tests to cover all functionalities and ensure everything is working correctly.

FIREFLY-1611: Refactor CacheManager: Simplify and Update Cache Usage
- Remove replication features
- Eliminate the 'sharing' requirement
- Rename or consolidate the existing cache buckets to better reflect the current usage of Ehcache.
@loitly loitly added this to the 2025.1 milestone Dec 21, 2024
@loitly loitly self-assigned this Dec 21, 2024
@loitly loitly force-pushed the FIREFLY-1608-redis-messaging-caching branch 2 times, most recently from 95d27b1 to fc86dbe Compare December 21, 2024 20:46
@loitly loitly force-pushed the FIREFLY-1608-redis-messaging-caching branch from fc86dbe to c597d76 Compare December 21, 2024 20:57
@loitly loitly marked this pull request as ready for review January 2, 2025 22:15
@loitly loitly requested review from robyww and dencoded January 2, 2025 22:15
@loitly loitly force-pushed the FIREFLY-1608-redis-messaging-caching branch from c7258a2 to 266e671 Compare January 4, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww Awaiting requested review from robyww

@dencoded dencoded Awaiting requested review from dencoded

At least 1 approving review is required to merge this pull request.

Assignees

@loitly loitly

Labels
Infrastructure
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
1 participant
@loitly